Pydata 0.15 - Githubissues

sunpy / sunpy-sphinx-theme

A Sphinx theme for SunPy and its affiliated packages.

BSD 2-Clause "Simplified" License

6 stars 12 forks source link

Pydata 0.15 #228

Closed Cadair closed 4 months ago

Cadair commented 10 months ago

This does actually change a few things and some colouring. I don't really have time to run them all down now.

fixes #224 fixes #223

Cadair commented 6 months ago

It will probably be next week when I am back at work I get back to this.

nabobalis commented 6 months ago

Yolo it is

nabobalis commented 6 months ago

Change https://pygments.org/styles/ on the light theme.

wtbarnes commented 6 months ago

The button that toggles light/dark is highlighted with a full orange block when you mouse over it which looks a bit awkward:

nabobalis commented 4 months ago

Current state of the last merge:

[x] The navbar background is white on lightmode (grey on latest), makes navbar text unreadable.
[x] Change pygments.org/styles on the light theme.
[x] The button that toggles light/dark is highlighted with a full orange block when you mouse over it which looks a bit awkward

Can't replicate this (hopefully pydata theme fixed these):

[ ] The sidebar border disconnects from the navbar when you scroll (does not do this on latest)
[ ] The navbar bottom border is grey here, should be the theme orange, like the sidebar border.

nabobalis commented 4 months ago

Fixes https://github.com/sunpy/sunpy-sphinx-theme/issues/223

nabobalis commented 4 months ago

Fixes https://github.com/sunpy/sunpy-sphinx-theme/issues/216

pydata theme already uses the quansight-labs.github.io/accessible-pygments package and we select two themes that are from this.

wtbarnes commented 4 months ago

I had just a quick scroll through it, using both the light and dark themes, but it looks great to me!

Cadair commented 4 months ago

I am not sure I am a massive fan of the new dark background colour in comparison to the old one?

Cadair commented 4 months ago

Other things I can spot:

the double underline for the things which support hoverref isn't ideal
The left side bar toggle button is misaligned in the nav bar
The top breadcrubs navigation is truncated (and not coloured) in the new build

wtbarnes commented 4 months ago

Can you request changes to block on this? It has two approvals so in theory could be merged as is.

nabobalis commented 4 months ago

Or these issues are moved to issues and are patched after this PR is released?

wtbarnes commented 4 months ago

Or that as well. I'm fine with either. I'd prefer the latter if these fixes are not straightforward.

Cadair commented 4 months ago

OK, I have addressed everything I would like to change, I have deliberately done it in small commits so that if people disagree with any of the stylistic choices we can easily undo.

Cadair commented 4 months ago

It seems that the breadcrumbs stuff is an upstream change not in CSS, so I am happy to just leave that.

Cadair commented 4 months ago

Thanks @nabobalis for the review and release. Thanks everyone else, sorry this took so long.