search

sunpy / sunpy-sphinx-theme

A Sphinx theme for SunPy and its affiliated packages.
BSD 2-Clause "Simplified" License
6 stars 13 forks source link

Fix two bugs + cards from website #263

Closed nabobalis closed 1 month ago

nabobalis commented 1 month ago

Fixes https://github.com/sunpy/sunpy-sphinx-theme/issues/256 Fixes https://github.com/sunpy/sunpy-sphinx-theme/issues/257

Cadair commented 1 month ago

The lack of hover-over on the card, and the fact that only the "more info" button is clickable rather than the whole card isn't ideal.

Also this has apparently broken sunpy.org?

Cadair commented 1 month ago

Yeah, I just rebuilt sunpy.org and the build succeeded but the cards are broken.

Cadair commented 1 month ago

It is also broken on the preview build on this PR https://output.circle-artifacts.com/output/job/5f17f6e9-6b09-4173-84d9-dccb1a3a1365/artifacts/0/.tmp/website/sunpy.org/_build/html/about/project/index.html

nabobalis commented 1 month ago

The lack of hover-over on the card, and the fact that only the "more info" button is clickable rather than the whole card isn't ideal.

This has always been the case tho?

It is also broken on the preview build on this PR output.circle-artifacts.com/output/job/5f17f6e9-6b09-4173-84d9-dccb1a3a1365/artifacts/0/.tmp/website/sunpy.org/_build/html/about/project/index.html

Hmm, I think I need to pass the path down to the card for the images.