Submit aiapy for review as an Affiliated Package

wtbarnes commented 4 years ago

Package Details

Package name: aiapy
Maintainer(s): Will Barnes, Mark Cheung
Repository: https://gitlab.com/LMSAL_HUB/aia_hub/aiapy
PyPI link (if applicable): https://pypi.org/project/aiapy/

Description of Package

aiapy is a Python package for analyzing data from the Atmospheric Imaging Assembly (AIA) instrument onboard NASA's Solar Dynamics Observatory spacecraft.

Package Review

Editor Submission Checklist

[x] Is the submission appropriate?
[x] Does the project have an appropriate license?
[x] Is the project in a version control repository?
[x] Does the project provide a Python interface?
[x] Is the project on PyPI?
[x] Is the project useful to the solar physics community?

Instructions to Reviewer

Please copy the following and select the ranking for each criteria, the full review criteria can be found here:

* Functionality           : General Package / Specialized Package / Not Relevant
* Integration             : Well integrated / Partially Integrated / Minimal Integration
* Documentation           : Extensive / Some / Little
* Testing                 : Excellent / Good / Needs Work
* Duplication             : None / Some / Major
* Community               : Excellent / Good / Needs Work
* Development Status      : Stable / Rapid Development / Low Activity / Needs Work

Cadair commented 4 years ago

@nabobalis Would you be able to review this for me?

nabobalis commented 4 years ago

10/10 would aiapy again.

nabobalis commented 4 years ago

Functionality : Specialized Package
Integration : Well integrated
Documentation : Extensive
Testing : Good (seems to have most functions covered)
Duplication : None (I wasn't able to see any)
Community : Good (This is hard to judge)
Development Status : Rapid Development (I assume)

Cadair commented 4 years ago

@wtbarnes / @nabobalis I can't see a reference to a Code of Conduct anywhere in the aiapy docs or repo. Am I missing it? (it's a requirement for the community section)

nabobalis commented 4 years ago

I probably missed it.

wtbarnes commented 4 years ago

Oops 😬

wtbarnes commented 4 years ago

https://gitlab.com/LMSAL_HUB/aia_hub/aiapy/-/merge_requests/64

wtbarnes commented 4 years ago

the pycodestyle test is complaining about formatting in the CoC file 🤣

sunpy / sunpy.org