search

sunriseos / SunriseOS

Horizon/NX kernel reimplementation
Apache License 2.0
232 stars 13 forks source link

FS: StorageCachedBlockDevice should live in storage-device #466

Open roblabla opened 5 years ago

roblabla commented 5 years ago

StorageCachedBlockDevice is truthfully a fancy StorageBlockDevice<CachedBlockDevice>. The only difference between the two is that it has a special read method that is totally broken handles misaligned blocks in a somewhat efficient way. There's no reason why this function couldn't be implemented on StorageBlockDevice.

@Orycterope since you're going to be fixing the broken read method anyways, I think you should move it to storage_device at the same time.

Orycterope commented 5 years ago

yep, that was my plan all along