search

sunscrapers / django-templated-mail

Send emails using Django template system.
MIT License
95 stars 22 forks source link

Added support for from_email field to send method #2

Closed dkainama closed 6 years ago

dkainama commented 6 years ago

EmailMultiAlternatives supports from_email, added support for this field and written a test

https://docs.djangoproject.com/en/2.0/topics/email/

codecov-io commented 6 years ago

Codecov Report

Merging #2 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #2   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          54     55    +1     
=====================================
+ Hits           54     55    +1
Impacted Files Coverage Δ
templated_mail/mail.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e967bb5...c444134. Read the comment docs.

pszpetkowski commented 6 years ago

Looks good 🎉 Thank you very much for your work and sorry you had to wait.

dkainama commented 6 years ago

Thanks, no problem. Do you have a timeline for a new release of the pip package?

pszpetkowski commented 6 years ago

I'll be able to release new version next week - most probably monday.

dkainama commented 6 years ago

Thanks so much!