search

sunscrapers / django-templated-mail

Send emails using Django template system.
MIT License
95 stars 21 forks source link

Fix: from_email should return None by default #5

Closed dkainama closed 6 years ago

dkainama commented 6 years ago

If from_email is None, use the DEFAULT_FROM_EMAIL setting. https://docs.djangoproject.com/en/2.0/_modules/django/core/mail/#send_mail

@piotr-szpetkowski didn't see this problem. Tested against a SMTP server with from_email address set to None, this works. A string is indeed not valid.

This PR will fixes #4

codecov-io commented 6 years ago

Codecov Report

Merging #5 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #5   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          56     56           
=====================================
  Hits           56     56
Impacted Files Coverage Δ
templated_mail/mail.py 100% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ea1d09b...daaacc3. Read the comment docs.

pszpetkowski commented 6 years ago

Hi @dkainama - thank you for the quick fix, yeah, I overlooked this one.