search

sunscrapers / django-templated-mail

Send emails using Django template system.
MIT License
95 stars 21 forks source link

Update settings from dict format to variable format #7

Closed oliver-zhou closed 5 years ago

oliver-zhou commented 6 years ago

It seems that in django-templated-email, you're using straight variables inside the settings file, instead of a nested dictionary like in djoser, and the variable names should reflect that in the documentation for that

codecov-io commented 6 years ago

Codecov Report

Merging #7 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #7   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          56     56           
=====================================
  Hits           56     56

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bcadd81...8cbcbd9. Read the comment docs.

zefciu commented 5 years ago

This should wait for https://github.com/sunscrapers/django-templated-mail/pull/12 because the names should be changed after we merge that one.

zefciu commented 5 years ago

I think we should go the other way around here – change the way we load settings.