search

sunscrapers / djoser

REST implementation of Django authentication system.
MIT License
2.53k stars 459 forks source link

Support social-auth-app-django 5.0.0 #668

Open bj00rn opened 2 years ago

bj00rn commented 2 years ago

Hi,

Any reason why we can't support social-auth-app-django 5?

I see that the dependency has been upgraded in master already.

https://github.com/python-social-auth/social-app-django/blob/master/CHANGELOG.md#500---2021-08-05

Can we expect a release anytime soon?

Thanks!

bj00rn commented 2 years ago

https://github.com/sunscrapers/djoser/issues/655

bj00rn commented 2 years ago

https://github.com/sunscrapers/djoser/issues/651

skonikevrone commented 2 years ago

@dekoza @tomwojcik

New release would solve django 4 compatibility. social-auth-app-django 5 has important bug fix.

tomwojcik commented 2 years ago

@dekoza @tomwojcik

New release would solve django 4 compatibility. social-auth-app-django 5 has important bug fix.

We're not the maintainers anymore.

skonikevrone commented 2 years ago

@dekoza @tomwojcik New release would solve django 4 compatibility. social-auth-app-django 5 has important bug fix.

We're not the maintainers anymore.

Sorry to bother you. Any chance you know someone whom we can ping?

tomwojcik commented 2 years ago

@skonikevrone No problem. @haxoza is your best bet.

bj00rn commented 2 years ago

@haxoza we get a new release please you think?

Seems there are issues with latest commit on master. Commit https://github.com/sunscrapers/djoser/commit/ede06f257950705bbf6ded47d3c6daf11eb36fe3 is working fine though

sinisarudan commented 2 years ago

Yes, This issue requires hacks for social-auth-app-django like the one I have introduced https://github.com/python-social-auth/social-app-django/issues/386#issuecomment-1252114612 The contributor to the social-auth-app-django has answered:

Use social-auth-app-django==5.0.0 instead for compatiblity with recent Django releases.

that we cannot use actually, until Djoser doesn't overcome this dependency requirement:

Cannot install ... social-auth-app-django==5.0.0 because these package versions have conflicting dependencies.

The conflict is caused by:
    The user requested social-auth-app-django==5.0.0
    djoser 2.1.0 depends on social-auth-app-django<5.0.0 and >=4.0.0
albjoaov commented 1 year ago

Hello! Any updates on this?

Geg3mon commented 1 year ago

Hi, in your settings.py

import django
from django.utils.encoding import force_str
django.utils.encoding.force_text = force_str
bj00rn commented 1 year ago

@dekoza @tomwojcik

Any other guesses to to who maintains this repo? @haxoza is unresponsive it seems.

This is a showstopper for many who are using this library

Thanks!

tomwojcik commented 1 year ago

@bj00rn I will take over from now on, but I can spend only a few hours a month on this project. I will look over the issues soon. For now, the new release is the top prio.

bj00rn commented 1 year ago

@bj00rn I will take over from now on, but I can spend only a few hours a month on this project. I will look over the issues soon. For now, the new release is the top prio.

Good news!