search

sunsheng / gitiles

Automatically exported from code.google.com/p/gitiles
0 stars 0 forks source link

format=TEXT for +diff handler #55

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Probably would be base64 encoded. This would allow web-based tools to get the 
diff content without needing to parse the HTML

Original issue reported on code.google.com by iannucci@chromium.org on 12 Jun 2014 at 11:04

GoogleCodeExporter commented 9 years ago

Original comment by iannucci@chromium.org on 12 Jun 2014 at 11:04

GoogleCodeExporter commented 9 years ago 
What do you mean by "web based tools? You want to embed this in an iframe or 
something?

Also just curious, why do you prefer text to json?

Original comment by dborowitz@google.com on 12 Jun 2014 at 11:06

GoogleCodeExporter commented 9 years ago 
Json would be fine too. The tool in question is actually doing processing of 
the diffs to correlate stack traces with patches.

Original comment by iannucci@chromium.org on 12 Jun 2014 at 11:10

GoogleCodeExporter commented 9 years ago 
web based as in -> doesn't have a local checkout

Original comment by iannucci@chromium.org on 12 Jun 2014 at 11:10

GoogleCodeExporter commented 9 years ago 
If it were in text the format would be the same as the output of "git diff", 
i.e. mostly standard Unix patch format (plus base64 encoding), so do you have a 
tool that is capable of understanding that already? If it were in JSON...not 
sure yet.

Also what's your timeline like?

Original comment by dborowitz@google.com on 13 Jun 2014 at 6:46

GoogleCodeExporter commented 9 years ago 
Timeline would probably be like 2-3 months or so. It's not urgent, but we 
should probably have it before we start trying to import BeautifulSoup or 
something

Original comment by iannu...@google.com on 27 Jun 2014 at 11:54

GoogleCodeExporter commented 9 years ago 
And, yes, we have tools to understand diff

Original comment by iannu...@google.com on 27 Jun 2014 at 11:54

GoogleCodeExporter commented 9 years ago

Original comment by iannucci@chromium.org on 27 Jun 2014 at 11:56

GoogleCodeExporter commented 9 years ago 
https://gerrit-review.googlesource.com/58383

Original comment by dborowitz@google.com on 10 Jul 2014 at 5:02