Closed 4meta5 closed 4 years ago
bounty
so pull out logic from runtime methods and put them in helper trait impls like the last commit does for court
For vote
, the expiry parameter is used but there is no method to extend the lifetime of a VoteState
For court
, the expiry parameter is in DisputeState
but is not enforced at all.
BankState
has a reserved
field for tracking the total amount of funds reserved for future spends. When we call unreserve
, we substract from this field but we CANNOT increase the transfer from which this reservation was derived because it might be in the withdrawal .state()
...so I am considering adding a .free
field to the BankState
object, just for spends that are unreserved()
.
The motivation for adding this field would be to track the funds that would be withdrawable by burning ownership in Org
that controls the respective bank
object. RageQuit
isn't a feature yet in the newest implementation because the above is unresolved.
.free
field to BankState
for RageQuit
and (2) also providing a path to go from TransferInformation.state() == FreeForSpending
to put the funds in .free
so that they are withdrawable only by burning shares (next, I would add a feature to spend/allocate these funds in .free
by vote
)I definitely want the CI to be green before merging. So a few TODOs before merging
In addition, there is a need for more testing and adding more functionality to the CLI. Both of those may be explored in future PRs because this one is getting big.
like 10 commits just to get the CI to work (not yet), why does the CI's compiler consistently return different results than my local compiler....
I removed the CI in this PR and added Cargo.lock instead
Re-implementing simplest subset of bank and bounty to get something that works with all of these...
proper readme