sunshine-protocol / sunshine

Governance + Bounty Platform
Other
43 stars 16 forks source link

changes #105

Closed 4meta5 closed 4 years ago

4meta5 commented 4 years ago

Re-implementing simplest subset of bank and bounty to get something that works with all of these...

proper readme

4meta5 commented 4 years ago
4meta5 commented 4 years ago

note to self

For vote, the expiry parameter is used but there is no method to extend the lifetime of a VoteState

For court, the expiry parameter is in DisputeState but is not enforced at all.

4meta5 commented 4 years ago

BankState has a reserved field for tracking the total amount of funds reserved for future spends. When we call unreserve, we substract from this field but we CANNOT increase the transfer from which this reservation was derived because it might be in the withdrawal .state()...so I am considering adding a .free field to the BankState object, just for spends that are unreserved().

The motivation for adding this field would be to track the funds that would be withdrawable by burning ownership in Org that controls the respective bank object. RageQuit isn't a feature yet in the newest implementation because the above is unresolved.

4meta5 commented 4 years ago

I definitely want the CI to be green before merging. So a few TODOs before merging

In addition, there is a need for more testing and adding more functionality to the CLI. Both of those may be explored in future PRs because this one is getting big.

4meta5 commented 4 years ago

like 10 commits just to get the CI to work (not yet), why does the CI's compiler consistently return different results than my local compiler....

4meta5 commented 4 years ago

I removed the CI in this PR and added Cargo.lock instead