[x] remove turnout requirement from vote, it adds unnecessary complexity and is misleading because the vote threshold is set once upon initialization
If I were to add more to vote, I'd add methods to create votes with other percentage thresholds:
34%
51%
67%
76%
I'd prefer to make it such that I replace unanimous_consent_vote with n% threshold requirement which would cover all of these. It would still be smart to make different CLI commands for the thresholds listed above and 100% for convenience.
The threshold should also be capped by the total voting power available and it isn't currently. This could lead to user errors.
vote
, it adds unnecessary complexity and is misleading because thevote
threshold is set once upon initializationIf I were to add more to
vote
, I'd add methods to create votes with other percentage thresholds:I'd prefer to make it such that I replace
unanimous_consent_vote
withn%
threshold requirement which would cover all of these. It would still be smart to make different CLI commands for the thresholds listed above and 100% for convenience.The threshold should also be capped by the total voting power available and it isn't currently. This could lead to user errors.