sunshine-protocol / sunshine

Governance + Bounty Platform
Other
43 stars 16 forks source link

vote module: threshold changes TODO #112

Closed 4meta5 closed 4 years ago

4meta5 commented 4 years ago

If I were to add more to vote, I'd add methods to create votes with other percentage thresholds:

I'd prefer to make it such that I replace unanimous_consent_vote with n% threshold requirement which would cover all of these. It would still be smart to make different CLI commands for the thresholds listed above and 100% for convenience.

The threshold should also be capped by the total voting power available and it isn't currently. This could lead to user errors.

4meta5 commented 4 years ago

Done