search

sunshine-protocol / sunshine

Governance + Bounty Platform
Other
43 stars 16 forks source link

some changes #120

Closed 4meta5 closed 4 years ago

4meta5 commented 4 years ago

took the bot out of this PR, it will be added back in a future PR

client use ipfs

Once these are complete, I need to release 0.2.0 for sunshine-bounty-client.

4meta5 commented 4 years ago
4meta5 commented 4 years ago

@dvc94ch should the methods in client take in a String instead of an AccountId so that we move the InvalidSs58 into the client? I'm not sure whether this is the right choice and whether my choice to have input types as String already in client is right.

My hunch is that this is what I should do. It would essentially remove sunshine-core as a dep for client/cli and it would remove the need for a custom client/cli error type (because all the errors would be in the client/client error type).

dvc94ch commented 4 years ago

No, it should take an AccountId. Although I'm still not happy with error handling, it's ok for now I guess