sunshine-protocol / sunshine

Governance + Bounty Platform
Other
43 stars 16 forks source link

running cargo clippy in the CI #38

Closed 4meta5 closed 4 years ago

4meta5 commented 4 years ago

I'm commenting the following out of the CI because I can't resolve the error that it emits

- name: cargo clippy
  run: cargo clippy -- -D warnings
error: this public function dereferences a raw pointer but is not marked `unsafe`
   --> /home/runner/work/sunshine-node/sunshine-node/runtime/src/lib.rs:288:1
    |
288 | / impl_runtime_apis! {
289 | |     impl sp_api::Core<Block> for Runtime {
290 | |         fn version() -> RuntimeVersion {
291 | |             VERSION
...   |
376 | |     }
377 | | }
    | | ^ in this macro invocation
    | |_|
    | 
    |
    = note: `#[deny(clippy::not_unsafe_ptr_arg_deref)]` on by default
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref

I've already tried

decision

should get in the habit of running this locally but I won't accept a permanent red X on the CI indicator when everything else works, it's just bad vibes (the color of the red X was designed to coax developers towards the green check) SO I'm taking it out for now

It would be nice if I could pass a flag into the cargo clippy command to ignore this warning

dvc94ch commented 4 years ago

I guess this can be closed?

4meta5 commented 4 years ago

ye