NOT a priority but it should be noted that vote-petition only inherits shares-membership (which inherts sunshine-org) and it only works when PetitionState.vote_id_reqs: (u32, u32) s.t. the first u32 is OrgId and the second is FlatShareId.
So to add support for org, we should basically add a path and change PetitionState.vote_id_reqs to an enum: { Org(u32), FlatSubOrg(u32, u32) }. We already have some variation of this and it is a common pattern. I think bank-offchain has a similar concept with SupportedOrganizationShape
NOT a priority, just wanted to write this down somewhere
4meta5
commented
4 years ago
NOT a priority but it should be noted that
vote-petitiononly inheritsshares-membership(which inhertssunshine-org) and it only works whenPetitionState.vote_id_reqs: (u32, u32)s.t. the first u32 isOrgIdand the second isFlatShareId.So to add support for
org, we should basically add a path and changePetitionState.vote_id_reqsto an enum:{ Org(u32), FlatSubOrg(u32, u32) }. We already have some variation of this and it is a common pattern. I thinkbank-offchainhas a similar concept withSupportedOrganizationShapeNOT a priority, just wanted to write this down somewhere