search

sunshine-protocol / sunshine

Governance + Bounty Platform
Other
43 stars 16 forks source link

CI fails because of client dependency check #80

Closed 4meta5 closed 4 years ago

4meta5 commented 4 years ago

It's just a bad look for the repo build to fail even though all the code in modules, node, and runtime compile, have tests, and are clippy compliant.

Here is the failed CI build

Run cd node && cargo fmt --all -- --check
Error during execution of `cargo metadata`:     Updating crates.io index
    Updating git repository `https://github.com/ipfs-rust/ipfs-embed`
    Updating git repository `https://github.com/spacejam/sled`
    Updating git repository `https://github.com/dvc94ch/substrate-subxt`
error: failed to load source for a dependency on `substrate-subxt`

Caused by:
  Unable to update https://github.com/dvc94ch/substrate-subxt?branch=lightclient

Caused by:
  Could not find `Cargo.toml` in `/home/runner/.cargo/git/checkouts/substrate-subxt-f4fabceada7f1f81/substrate/bin/node-template/node`

if I cd into node, why is it even updating those dependencies??? They are not dependencies of the node....

CC @dvc94ch ugh you know how much I hate the red checkmark and we're applying to stuff now so optics matters

4meta5 commented 4 years ago

The most recent commit to master tried to use paths from here https://help.github.com/en/actions/configuring-and-managing-workflows/configuring-a-workflow

I don't know how much more time I'll spend on this but I am happier now that there is no CI. No CI is better than a false negative CI....

4meta5 commented 4 years ago

just needed to comment the client out of the cargo workspace HAHAHAHAHHAHAHAHAA