sunshinejr / SwiftyUserDefaults

Modern Swift API for NSUserDefaults
http://radex.io/swift/nsuserdefaults/static
MIT License
4.85k stars 366 forks source link

Version 4.0.0 #155

Closed sunshinejr closed 6 years ago

sunshinejr commented 6 years ago

Fixes #146, #143, #141, #140, #121, #71, #60, #51, #88 Supersedes: #59, #95

It's happening guys. Most of the work is done.

In next versions I would like to look at:

But if anyone will want to help me out with them, would be awesome!

sunshinejr commented 6 years ago

Weird, build is failing but builds & tests & pod lint went fine. Might need to look into it tomorrow.

sunshinejr commented 6 years ago

Now that I think about it, I’ll probably just remove DefaultsCodableKey and you would just need to conform to DefaultsSerializable in your custom type without implementation (similar to the new NSCoding). I’ll also add a Sourcery template so it will be easier to generate comformances if there are many types in the App.

sunshinejr-bot commented 6 years ago
Warnings
:warning: Big PR, try to keep changes smaller if you can
:warning: Any changes to library code should be reflected in the Changelog.
:warning: PR is classed as Work in Progress

SwiftLint found issues

Severity File Reason
Error DefaultsSerializable+BuiltIns.swift:259 Force casts should be avoided.
Error DefaultsSerializable+BuiltIns.swift:263 Force casts should be avoided.

SwiftLint found issues

Severity File Reason
Error TestHelper.swift:103 Enum element name should start with a lowercase character: 'Andy'
Error TestHelper.swift:104 Enum element name should start with a lowercase character: 'Dandy'
Error TestHelper.swift:113 Enum element name should start with a lowercase character: 'Andy'
Error TestHelper.swift:114 Enum element name should start with a lowercase character: 'Dandy'
Warning TestHelper.swift:100 Limit vertical whitespace to a single empty line. Currently 2.
Warning TestHelper.swift:107 Limit vertical whitespace to a single empty line. Currently 2.
Warning TestHelper.swift:5 Prefer -> Void over -> ().
Warning TestHelper.swift:9 Prefer -> Void over -> ().
Warning TestHelper.swift:13 Prefer -> Void over -> ().

Generated by :no_entry_sign: dangerJS

sunshinejr commented 6 years ago

Updated docs, probably missed something but I'll iterate as we go.

On my way to release version 4.0.0-alpha.1! Live updates in #154 😱

farzadshbfn commented 5 years ago

We're still iterating phases? when will we have 4.0.0-alpha.1 removed and move onto 4.0.0 🤩?