search

sunshinejr / SwiftyUserDefaults

Modern Swift API for NSUserDefaults
http://radex.io/swift/nsuserdefaults/static
MIT License
4.85k stars 366 forks source link

All paths through this function will call itself #164

Closed cyrille-legrand closed 5 years ago

cyrille-legrand commented 6 years ago

Xcode 10 beta 5, Swift 4.2

Emits two warnings about "All paths through this function will call itself" on DefaultsSerializable+Builtins.swift on these two functions :

extension Array: DefaultsSerializable where Element: DefaultsSerializable {
    public static func getArray(key: String, userDefaults: UserDefaults) -> [[Element]]? {
        return [Element].getArray(key: key, userDefaults: userDefaults)
    }

    public static func saveArray(key: String, value: [[Element]], userDefaults: UserDefaults) {
        [Element].saveArray(key: key, value: value, userDefaults: userDefaults)
    }
}

https://github.com/radex/SwiftyUserDefaults/blob/4318092d12439887cd9b9b30d4d0e06b7867146b/Sources/DefaultsSerializable%2BBuiltIns.swift#L184

mman commented 5 years ago

@radex Any update on this one? If you try to outline here how is the Array extension supposed to work, I will try to cut a PR for you...