search

sunshinejr / SwiftyUserDefaults

Modern Swift API for NSUserDefaults
http://radex.io/swift/nsuserdefaults/static
MIT License
4.85k stars 366 forks source link

SwiftyUserDefaults.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion. #173

Closed gabors closed 5 years ago

gabors commented 5 years ago

Hi guys

Tried the latest release, commit github "radex/SwiftyUserDefaults" "f7878b0ae7b39dee85df6cf60b4d361af327e654", integrated via Carthage

Getting this when uploading to AppStoreConnect, just FYI

This bundle Payload/<myapp>.app/Frameworks/SwiftyUserDefaults.framework is invalid. The Info.plist file is missing the required key: CFBundleVersion.

sunshinejr commented 5 years ago

Hey @gabors, thanks for the heads-up! Is this a warning or an error?

gabors commented 5 years ago

No worries and thank you for an excellent framework.

This is an error, sometimes it gets caught by the Application loader, and once upload to ASC worked but the processing on Apple side failed and the email with the message above arrived.

sunshinejr commented 5 years ago

Okay, thanks! If you want to poke around and see if you can fix it and make a PR - it would be awesome. If not, I will take a look at it tomorrow, so no worries.

sunshinejr commented 5 years ago

@gabors could you check PR #174 and see if the error goes away? Would appreciate that before merging and releasing a new version!

sunshinejr commented 5 years ago

@gabors I've merged this one into the master, gonna release 4.0.0-alpha.3 in a sec as well. Please let me know once you try it out!

gabors commented 5 years ago

@sunshinejr Thanks very much, I'll try to build/upload to TestFlight and report back!

gabors commented 5 years ago

@sunshinejr I've tried a few TestFlight / AppStoreConnect uploads using github "radex/SwiftyUserDefaults" "cc1519f3fc88f8955b35ca15d9d316d15b317ea7"

Unfortunately the apps failed processing:

We identified one or more issues with a recent delivery for your app. Please correct the following issues, then upload again.

Invalid Bundle - One or more dynamic libraries that are referenced by your app are not present in the dylib search path.

Invalid Bundle - The app uses Swift, but one of the binaries could not link to it because it wasn't found. Check that the app bundles correctly embed Swift standard libraries using the "Always Embed Swift Standard Libraries" build setting, and that each binary which uses Swift has correct search paths to the embedded Swift standard libraries using the "Runpath Search Paths" build setting.

sunshinejr commented 5 years ago

@gabors okay that’s a different one then. Are you sure you did setup the framework correcty? If you use Carthage, you might’ve skipped adding the input/output to your build phase maybe?

gabors commented 5 years ago

Yeah I’m using Carthage but the integration works fine with the prior version of this framework.

sunshinejr commented 5 years ago

Okay then. Could you please try this branch and see if it makes a difference?

sunshinejr commented 5 years ago

@gabors I've played with @rpath and updated it to support macOS/iOS better. After archiving it seems that the path for linker is correctly resolved so if you'd have a chance to use fix/carthage_linking branch it would be awesome.

sunshinejr commented 5 years ago

Alright, released version 4.0.0-beta.2 with regenerated project that should fix the linking issue now. Let me know once you'll have some time to test it out @gabors.