Closed sunshinejr closed 5 years ago
sunshinejr-bot
commented
5 years ago | Warnings | |
|---|---|
| :warning: | Big PR, try to keep changes smaller if you can |
| :warning: | PR is classed as Work in Progress |
Generated by :no_entry_sign: Danger Swift against 6fa3e902b6a75d664c36b8eb117becc758949bd1
sunshinejr
commented
5 years ago Interesting @f-meloni would you have a second to take a look at this? For some reason danger-swift cannot parse the swiftlint result, but I'm not sure why, maybe you'll have an idea.
f-meloni
commented
5 years ago Yep will have a look tomorrow morning :)
sunshinejr
commented
5 years ago Oh that would be awesome! Thanks!
f-meloni
commented
5 years ago Worked 🎉
sunshinejr
commented
5 years ago Perfect! Thanks for the help @f-meloni, means a lot :) Probably would spend few more hours to realize that something messed up with the Swiftlint output 🤦♂️
f-meloni
commented
5 years ago No problem, happy to be useful :)
sunshinejr
commented
5 years ago Seems to be working, just need to update documentation and we are good to go. Gonna do that tomorrow! 🎉
Supersedes #118 and #67. Fixes #87.
This PR got quickly out of hands when I started doing Linux support at the same time 🙈 It won't be there for the next beta, but I would like to get some Linux support before the release.
TODO:
DefaultsSerializable.