Deployment target warning for Swift Package Manager for Xcode 12

sunshinejr / SwiftyUserDefaults

Modern Swift API for NSUserDefaults

http://radex.io/swift/nsuserdefaults/static

MIT License

4.84k stars 364 forks source link

Deployment target warning for Swift Package Manager for Xcode 12 #261

Closed yuukiw00w closed 3 years ago

yuukiw00w commented 3 years ago

In Xcode 12.0, the minimum supported deployment target is iOS 9.0. Consequently, SwiftyUserDefaults explicitly choosing iOS 8 as a minimum deployment target results in an error:

The iOS Simulator deployment target 'IPHONEOS_DEPLOYMENT_TARGET' is set to 8.0, but the range of supported deployment target versions is 9.0 to 14.0.99.

sunshinejr commented 3 years ago

Ah, yeah we should bump that to 9.0. @yuukiw00w would you be able to create a PR for that maybe? If not no problem, I will try to get to this ASAP.

yuukiw00w commented 3 years ago

Sorry I have no experience of library development. I think only need to fix the following 3 lines, but are they correct? https://github.com/sunshinejr/SwiftyUserDefaults/blob/master/SwiftyUserDefaults.podspec#L11 https://github.com/sunshinejr/SwiftyUserDefaults/blob/master/Package.swift#L29 https://github.com/sunshinejr/SwiftyUserDefaults/blob/master/FrameworkSpec#L4