Open jayatsandia opened 3 years ago
Actually, I think all that's needed is to change the IntIslandCat desc to "Setting for intentional island categories" which should be implied since it's under the "settings" heading in 702, but it would help if someone is working from pysunspec2 like I was.
Last thoughts on this... it may be better to have the names for the IntIslandCat changed to the following:
{
"access": "RW",
"desc": "Intentional island categories",
"label": "Intentional Island Categories",
"name": "IntIslandCat",
"notes": "",
"symbols": [
{
"name": "UNCATEGORIZED",
"notes": "",
"value": 0
},
{
"name": "INT_ISL_ENABLED",
"notes": "",
"value": 1
},
{
"name": "BLACK_START_ENABLED",
"notes": "",
"value": 2
},
{
"name": "ISOCH_ENABLED",
"notes": "",
"value": 3
}
],
"type": "bitfield16"
},
Good having owners feedback 🙄
I presume the IntIslandCatRtg is the modes that are supported in the DER and IntIslandCat is the mode(s) that are enabled? Could we clarify in the descriptions. Maybe something like:
https://github.com/sunspec/models/blob/09b35b5e6e55ff9404de5d8c659031e671cc4871/json/model_702.json#L322