sunspec / models

SunSpec Model Definitions
Apache License 2.0
84 stars 52 forks source link

Order of Reactive Power Reference Enumerations #228

Closed jsbosch closed 2 years ago

jsbosch commented 2 years ago

I suggest moving VAR_AVAL_PCT to the end of the list of enumerated values because this one is optional and by moving it to the end the SunSpec interface can use a simple range check for supporting that X_MAX_PCT values. This occurs in models 704 (in VarSetMod) and in 705 and 712 (in DeptRef).

If any of the X_MAX_PCT values are also optional, then I suggest moving that before VAR_AVAL_PCT.

jsbosch commented 2 years ago

Too late, spec is frozen.