search

sunspec / models

SunSpec Model Definitions
Apache License 2.0
84 stars 52 forks source link

303 TmpBOM Scalefactor: -1 #236

Open andig opened 1 year ago

andig commented 1 year ago

Seems this should be a string value? What does a fixed integer scale factor mean? Are the JSON models passing JSON schema validation?

andig commented 1 year ago

Seems they don‘t: https://github.com/sunspec/models/issues/62

andig commented 1 year ago

Same with models 304 and 63001.

nielsbasjes commented 1 year ago

According to the schema ( https://github.com/sunspec/models/blob/master/json/schema.json#L104 ) it is either the name of a point that contains the scale factor value OR it is a hardcoded value in the schema.

I wrote some code to verify this all ( https://github.com/sunspec/models/pull/243 ) and this all passes.