sunspec / models

SunSpec Model Definitions
Apache License 2.0
93 stars 52 forks source link

Model name in XML has no corresponding field in spreadsheet #24

Open altendky opened 7 years ago

altendky commented 7 years ago

A model's 'name' shows up three times in the XML file (see below). In the case of model 103 there are two different values between the three locations. The spreadsheet has the name once on the index page and again as the ID point's label. In both cases in the spreadsheet it is 'Inverter (Three Phase)'. It would be nice to have the spreadsheet include the <model name="..."> version (simply "inverter") for reference since that is what is used by the sunspec/pysunspec library.

Other values address this by having the 'computer name' in the 'Name' column and the 'human name' in the 'Label' column, but since the 'Name' for the model must be 'ID' we are left with this missing piece.

https://github.com/sunspec/models/blob/94a0d35a2db8f011f88d1fa62424046bc11709b8/smdx/smdx_00103.xml

  <!-- 103: inverter -->
  <model id="103" len="50" name="inverter">
  <strings id="103" locale="en">
    <model>
      <label>Inverter (Three Phase)</label>
ghost commented 5 years ago

Currently reviewing model naming