search

sunspec / models

SunSpec Model Definitions
Apache License 2.0
84 stars 52 forks source link

SunSpec Workgroup Model Updates #251

Open dersecure opened 2 weeks ago

cla-bot[bot] commented 2 weeks ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @dersecure on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

jsbosch commented 2 weeks ago

I don't think we can go just adding fields like that.

On Mon, Jun 17, 2024 at 11:00 AM Jay Johnson @.***> wrote:

You can view, comment on, or merge this pull request online at:

https://github.com/sunspec/models/pull/251 Commit Summary

File Changes

(17 files https://github.com/sunspec/models/pull/251/files)

Patch Links:

— Reply to this email directly, view it on GitHub https://github.com/sunspec/models/pull/251, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7QRPK7DQSGJC2SEVV5PILZH4P43AVCNFSM6AAAAABJOPFEKSVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM2TOOJRGYYDAMQ . You are receiving this because you are subscribed to this thread.Message ID: @.***>

cla-bot[bot] commented 2 weeks ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @dersecure on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

cla-bot[bot] commented 2 weeks ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @dersecure on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

cla-bot[bot] commented 2 weeks ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @dersecure on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

cla-bot[bot] commented 2 weeks ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @dersecure on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

cla-bot[bot] commented 2 weeks ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @dersecure on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

dersecure commented 2 weeks ago

@jsbosch In a small subgroup we discussed adding this field to the schema to help users quickly identify points required for standards around the world (US, Poland, etc.). SunSpec agreed that this would be a helpful expansion. We would appreciate your view on this addition.

jsbosch commented 2 weeks ago

Won't adding a field to the schema break existing implementations?

On Mon, Jun 17, 2024 at 1:23 PM Jay Johnson @.***> wrote:

@jsbosch https://github.com/jsbosch In a small subgroup we discussed adding this field to the schema to help users quickly identify points required for standards around the world (US, Poland, etc.). SunSpec agreed that this would be a helpful expansion. We would appreciate your view on this addition.

— Reply to this email directly, view it on GitHub https://github.com/sunspec/models/pull/251#issuecomment-2174356941, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7QRPLBXAVPRQDRCLJ4VU3ZH5ATLAVCNFSM6AAAAABJOPFEKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZUGM2TMOJUGE . You are receiving this because you were mentioned.Message ID: @.***>

cla-bot[bot] commented 2 weeks ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @dersecure on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

cla-bot[bot] commented 2 weeks ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @dersecure on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

cla-bot[bot] commented 2 weeks ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @dersecure on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

cla-bot[bot] commented 2 weeks ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @dersecure on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

jsbosch commented 2 weeks ago

On closer examination, I think I see that you're only adding metadata, not SunSpec points. Is that correct? If so, I withdraw my comments.

On Mon, Jun 17, 2024 at 3:19 PM cla-bot[bot] @.***> wrote:

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @dersecure https://github.com/dersecure on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

— Reply to this email directly, view it on GitHub https://github.com/sunspec/models/pull/251#issuecomment-2174530723, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7QRPIK5SG2TNOIAOMHUS3ZH5OGVAVCNFSM6AAAAABJOPFEKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZUGUZTANZSGM . You are receiving this because you were mentioned.Message ID: @.***>

cla-bot[bot] commented 2 weeks ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @dersecure on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

cla-bot[bot] commented 2 weeks ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @dersecure on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

dersecure commented 2 weeks ago

@jsbosch Yes, this update will not change the number, type, or names of the points but provide clarification on how to use them and what standards require their implementation.

jsbosch commented 2 weeks ago

Thanks for the clarification. Wouldn't it be better to decouple the points from the standards and have a standards implementation spec define which fields are required? Seems like it could get cluttered otherwise.

On Mon, Jun 17, 2024 at 5:29 PM Jay Johnson @.***> wrote:

@jsbosch https://github.com/jsbosch Yes, this update will not change the number, type, or names of the points but provide clarification on how to use them and what standards require their implementation.

— Reply to this email directly, view it on GitHub https://github.com/sunspec/models/pull/251#issuecomment-2174681672, or unsubscribe https://github.com/notifications/unsubscribe-auth/AC7QRPM527VUC5XSLNJOCH3ZH55PTAVCNFSM6AAAAABJOPFEKSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZUGY4DCNRXGI . You are receiving this because you were mentioned.Message ID: @.***>

cla-bot[bot] commented 1 week ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @dersecure on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

cla-bot[bot] commented 1 week ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @dersecure on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

cla-bot[bot] commented 1 week ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @dersecure on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.

cla-bot[bot] commented 1 week ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @dersecure on file. In order for us to review and merge your code, please contact the project maintainers to get yourself added.