search

sunspec / pysunspec2

SunSpec Python library for interfacing with SunSpec devices.
Apache License 2.0
57 stars 22 forks source link

smdx.from_smdx() does not put `size` attribute in points #34

Closed jmmgenerac closed 3 years ago

jmmgenerac commented 3 years ago

https://github.com/sunspec/pysunspec2/blob/4405d92786733f1fed118be9c468eaaf97ca8b1d/sunspec2/smdx.py#L159

When using smdx.from_smdx() to convert from smdx files to dictionary, the size attribute is not created.

As a workaround, I found that using smdx.from_smdx() -> spreadsheet.to_spreadsheet() -> spreadsheet.from_spreadsheet() seems to do the job.

However, it would be great if smdx.from_smdx() performed the proper conversion on its own.

bobfox commented 3 years ago

We will add this in the update coming out this week.