sunspikes / php-ratelimiter

A framework independent rate limiter for PHP
MIT License
66 stars 12 forks source link

Use PSR-6 caching interfce & remove desarolla2 cache #10

Closed sunspikes closed 7 years ago

sunspikes commented 7 years ago
sunspikes commented 7 years ago

Hi @Feijs

Can you please have a look. So basically i removed Desarrola completely and decoupled the caching part (it now depends only on PSR-6 interfaces), for functional tests I'm using the array cache from php-cache and I've started using PHP 7 typehints.

Now for v2 i think,

That's what i can think of now, what you think ?

sunspikes commented 7 years ago

Why have these been removed? I can update them to match your changes in this PR if that is the issue?

It would be awesome if you can add it back. Now all of them fails because of these new changes, i've tried to fix it but it was not good as i wanted it to be :D

@Feijs Also, thank you so much for your comments!

sunspikes commented 7 years ago

I will merge this to the release branch, if there is something to be addressed it can be done in a new PR.