search

sunspikes / php-ratelimiter

A framework independent rate limiter for PHP
MIT License
66 stars 12 forks source link

Return type in v8.1 #16

Open raicho opened 1 year ago

raicho commented 1 year ago

Just reporting notice in 8.1.
"Return type of Sunspikes\Ratelimit\Throttle\Throttler\ElasticWindowThrottler::count() should either be compatible with Countable::count(): int, or the #[\ReturnTypeWillChange].

plotbox-io commented 1 year ago

Have added a pull request to solve. Not sure if this repo is maintained going by the last commits :-/ but we'll be using our fork for time being to get around this - https://github.com/plotbox-io/php-ratelimiter

sebclick commented 8 months ago

Hello @sunspikes Is a new version planned to take these changes into account ? Thanks,