Improvement: abstract and inject ratelimiter depedencies

sunspikes / php-ratelimiter

A framework independent rate limiter for PHP

MIT License

63 stars 12 forks source link

Improvement: abstract and inject ratelimiter depedencies #3

Closed Feijs closed 8 years ago

Feijs commented 8 years ago

The goal of this PR is to improve flexibility. With these changes, the Ratelimiter class can be used with custom hydrators, throttlers and/or cacheadapter.

Changes:

Interfaced & injected the hydrator factory
Config has been moved to the cache factory, since it is only used there. This simplifies the Ratelimiter class
Global ratelimiter limit & ttl are no longer overwritten when fetching a new throttler

sunspikes commented 8 years ago

Thank you so much for the PR!, can you please check the comments...

sunspikes commented 8 years ago

Awesome!, merged..

Feijs commented 8 years ago

Thanks for the quick feedback and merge!