search

sunwxg / gnome-shell-extension-switchworkspace

MIT License
17 stars 3 forks source link

support `shift` modifier to reverse switching direction #1

Closed problame closed 4 years ago

problame commented 4 years ago

As a GNOME user, I would find it helpful if the workspace switcher provided by this extension supported the Shift modifier, just like the stock GNOME window / app switcher.

I.e., while pressing Shift in addition to whatever the user configured as the workspace-switcher shortcut, the direction in which we cycle through the MRU workspaces should be reversed.

problame commented 4 years ago

Thanks for following up on this so quickly! I tested your commit, but when I load the extension, I get a JS Error in Gnome Shell, and the extension does not work.

gnome-extensions pack ./switchWorkSpace@sun.wxg@gmail.com
gnome-extensions install switchWorkSpace@sun.wxg@gmail.com.shell-extension.zip
gnome-extensions enable switchWorkSpace@sun.wxg@gmail.com
# alt-f2 r
Mär 25 11:20:37 cstp gnome-shell[5953]: JS ERROR: Extension switchWorkSpace@sun.wxg@gmail.com: ImportError: No JS module 'convenience' found in search path
                                         @/home/cs/.local/share/gnome-shell/extensions/switchWorkSpace@sun.wxg@gmail.com/extension.js:20:7
                                         _callExtensionInit@resource:///org/gnome/shell/ui/extensionSystem.js:343:13
                                         loadExtension@resource:///org/gnome/shell/ui/extensionSystem.js:277:22
                                         _loadExtensions/<@resource:///org/gnome/shell/ui/extensionSystem.js:490:13
                                         collectFromDatadirs@resource:///org/gnome/shell/misc/fileUtils.js:27:17
                                         _loadExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:469:9
                                         _enableAllExtensions@resource:///org/gnome/shell/ui/extensionSystem.js:499:13
                                         _sessionUpdated@resource:///org/gnome/shell/ui/extensionSystem.js:530:13
                                         init@resource:///org/gnome/shell/ui/extensionSystem.js:48:9
                                         _initializeUI@resource:///org/gnome/shell/ui/main.js:242:5
                                         start@resource:///org/gnome/shell/ui/main.js:138:5
                                         @<main>:1:31
sunwxg commented 4 years ago

Go to repo folder and run make install to install the extension.

problame commented 4 years ago

Did that, and neither Alt-F2 r nor a full reboot help. I'm on Fedora 31.

sunwxg commented 4 years ago

Oh, it only works on GNOME 3.36 now.