sunwxg / gnome-shell-extension-unblank

MIT License
99 stars 14 forks source link

Only unblank on main power #15

Closed curvatura99 closed 4 years ago

curvatura99 commented 4 years ago

The behavior for this option is as follows when enabled on my Lenovo 320 ideapad:

Pull the power cord, verify laptop is in powersave mode, then lock the screen. The lock screen comes down and the screen does not go blank.

Lock the screen, verify laptop is in powersave mode via ssh, then pull the power cord. Screen goes blank. Pressing any key or using the touchpad does nothing to make the screen re-appear. Only after reconnecting the power cord does the lock screen re-appear.

I'm pretty sure this is not the intended behavior.

sunwxg commented 4 years ago

Thank you, I will work on it.

curvatura99 commented 4 years ago

谢谢 - I know you'll make the extension even better.

sunwxg commented 4 years ago

I updated the repo, could you do a test?

curvatura99 commented 4 years ago

With the update if you pull the power cord and lock the screen it goes blank. However if you lock the screen and then pull the power cord the screen does not go blank. Unsure how you want the behavior, but at least now when you lock the screen on battery the screen does go blank.

curvatura99 commented 4 years ago

I have more information. When you lock the screen and then pull the power cord the screen does not blank, however the screen will blank eventually based on the power settings. I can now say your update was a success. Thank you so much.

sunwxg commented 4 years ago

Thanks! Closed.

curvatura99 commented 4 years ago

Just to let you know the extension from the master works with battery power. However the recent update at extensions.gnome.org is using the previous code in prefs.js and extension.js, so of course it doesn't work. Are you doing some more testing before releasing? Thanks.

sunwxg commented 4 years ago

I will send the latest code to extensions.gnome.org.

curvatura99 commented 4 years ago

I appreciate all the work you're doing. Thanks again.