suny-downstate-medical-center / netpyne

A Python package to facilitate the development, parallel simulation, optimization and analysis of multiscale biological neuronal networks in NEURON.
http://www.netpyne.org
MIT License
144 stars 135 forks source link

use PointCell params defined in `cellParams` as default values #698

Closed vvbragin closed 1 year ago

vvbragin commented 2 years ago

if such params are not customized in popParams

vvbragin commented 1 year ago

need to update the schema

vvbragin commented 1 year ago

The proposal is to avoid the inconsistency we currently have when declaring point cell params in cellParams vs in popParams. E.g., currently the same point cell can be described in cellParams as:

netParams.cellParams['artif_NetStim'] = {
    'cellModel': 'NetStim',
    'params': {'rate': 5}
}

and in popParams as:

netParams.popParams['pop_NetStim'] = {
    'cellModel': 'NetStim', 
    'numCells': 100,
    'rate': 5, 
}

I think it makes sense to use same approach for both cellParams and popParams: either (1) use params dictionary, or (2) have all properties at the top level, without nesting in 'params'.