suoto / hdl_checker

Repurposing existing HDL tools to help writing better code
GNU General Public License v3.0
187 stars 22 forks source link

Fix nvim lsp #98

Closed bramhooimeijer closed 2 years ago

bramhooimeijer commented 2 years ago

Hi Suoto,

Recently, Neovim's lspconfig has implemented broken changes again. This should fix the issue.

I also took the liberty to clean things up a bit. Feel free to adapt as you see fit.

Thanks for your efforts, Bram

Tested on nvim 0.7.0-dev, lspconfig current master (2c70b7b).

codecov-commenter commented 2 years ago

Codecov Report

Merging #98 (8952d10) into master (0dfeb84) will decrease coverage by 5.70%. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   94.98%   89.27%   -5.71%     
==========================================
  Files          31       31              
  Lines        2733     2733              
  Branches      401      401              
==========================================
- Hits         2596     2440     -156     
- Misses         88      236     +148     
- Partials       49       57       +8     
Impacted Files Coverage Δ
hdl_checker/builders/ghdl.py 48.14% <0.00%> (-46.92%) :arrow_down:
hdl_checker/builders/xvhdl.py 56.45% <0.00%> (-43.55%) :arrow_down:
hdl_checker/builders/msim.py 64.75% <0.00%> (-30.33%) :arrow_down:
hdl_checker/server.py 72.97% <0.00%> (-24.33%) :arrow_down:
hdl_checker/parser_utils.py 85.16% <0.00%> (-9.04%) :arrow_down:
hdl_checker/utils.py 89.34% <0.00%> (-8.29%) :arrow_down:
hdl_checker/builders/base_builder.py 86.70% <0.00%> (-4.44%) :arrow_down:
hdl_checker/diagnostics.py 94.62% <0.00%> (-1.08%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0dfeb84...8952d10. Read the comment docs.

suoto commented 2 years ago

Hey, sorry for taking so long to reply and thanks for the fix!