Add support for URI in signature to goto_uri

sup-heliotrope / sup

A curses threads-with-tags style email client (mailing list: supmua@googlegroups.com)

http://sup-heliotrope.github.io

GNU General Public License v2.0

900 stars 97 forks source link

Add support for URI in signature to goto_uri #527

Closed kalifg closed 4 years ago

kalifg commented 7 years ago

Background

The goto_uri function works fine in the body of the message, but when attempting to use it on a URL in the signature I received the message No URI found.

Solution

The code was considering only text marked in :text_color, while signatures use :sig_color. I have modified the logic to include this as well.

danc86 commented 4 years ago

Thanks for this patch, it looks good to me. If you could rebase this on the latest develop branch we should get a passing Travis build.

IPv2 commented 4 years ago

@kalifg Alternatively: if you're no longer interested (e.g., not a sup user any longer) then I'm happy to rebase for you and raise a new PR, crediting you.

IPv2 commented 4 years ago

Thanks @kalifg!

Looks good to me.

kalifg commented 4 years ago

You're welcome! I haven't used it in a while, but with the new activity I'll be sure to give it another look.