search

sup-heliotrope / sup

A curses threads-with-tags style email client (mailing list: supmua@googlegroups.com)
http://sup-heliotrope.github.io
GNU General Public License v2.0
900 stars 97 forks source link

Add rubocop-packaging checks #582

Closed IPv2 closed 4 years ago

IPv2 commented 4 years ago

rubocop-packaging automatically detects common packaging issues which may make life more difficult for downstream maintainers.

We add and execute off to the side, i.e., contained entirely within a new subdirectory inside contrib, including its own separate Bundler directory for gems. This is to avoid a hard development dependency in the main Sup project on the rubocop-packaging gem, because it is currently a very new project - started one month ago in 2020-06.

Rake task rubocop_packaging added to execute the checks. Called by task travis, used by Travis CI.

With thanks to Utkarsh Gupta \utkarsh@debian.org\ for the original idea (see PR #580).

IPv2 commented 4 years ago

Merged. Thanks @danc86 & @utkarsh2102.