search

sup3rgiu / PoliDown

Save Microsoft Stream videos uploaded by Politecnico di Milano.
MIT License
78 stars 13 forks source link

Add option to opt-out of using system keyring #9

Closed ghost closed 4 years ago

ghost commented 4 years ago

After #5 (commit e017cd1) I had some problems on Linux; as reported in this issue (https://github.com/Foundry376/Mailspring/issues/681) and other, node-keytar works only with libsecret, and libsecret only works with gnome-keyring. Since I don't use gnome, I think it would be better to have an option not to use it, much like there is a way to not use it if X11 is not installed. I have absolutely no problem with version before commit e017cd1.

I suggest maybe having a command line option to explicitly say not to use the keyring.

sup3rgiu commented 4 years ago

Passing the password as argument should skip the keytar block. Which error do you get?

Because with the current release, even if password argument is not passed, the try-catch block should detect all the problems with keytar, but always prints "X11 message"

lucio97 commented 4 years ago

+1 for this one, i would like to have the choice to use the keyring or not. with the new release, the program automatically save it to the keyring

ghost commented 4 years ago

I had this message printed ** Message: 13:21:34.812: Remote error from secret service: org.freedesktop.DBus.Error.ServiceUnknown: The name org.freedesktop.secrets was not provided by any .service files but now I can't replicate this. I still get this message, but it used to block the program, now it prints the error and keeps working like usual.

sup3rgiu commented 4 years ago

Added boolean flag -k to avoid keyring usage. commit 97f47c84814cf6a00ba05b94f58eac31cea323da

Let me know if this solve your problem

sup3rgiu commented 4 years ago

I'm closing this issue because it has been inactive for a few months.