supabase-community / auth-ui

Pre-built Auth UI for React
https://supabase.com/docs/guides/auth/auth-helpers/auth-ui
MIT License
488 stars 121 forks source link

"Already have an account? Sign in" appears in places where this text doesn't make sense #254

Open kav opened 8 months ago

kav commented 8 months ago

Bug report

When using Magic Links "Already have an account? Sign in" shows at the bottom of the magic link UI. This text is confusing as magic link is already a sign in mechanism for users with an account.

Describe the bug

When using Magic Links "Already have an account? Sign in" shows at the bottom of the magic link UI. This text is confusing as magic link is already a sign in mechanism for users with an account.

To Reproduce

create an <Auth /> component with magicLink. Click Send a magic link email

Expected behavior

"Sign in with a password or 3rd party auth provider" or a similar message should appear by default instead. "Already have an account? Sign in" should only appear on the Sign Up page.

Note the fact that you can override this message isn't a fix it's a workaround and doesn't solve the issue that the text to return to Login from Signup should not be the same as the text to return to Login from Magic Link (or Reset Password for that matter)

Screenshots

image

Additional context

Also #191 is still an issue. By default "Already have an account? Sign in" doesn't make sense as the text to return to the login screen from the forgot password screen