supabase-community / auth-ui

Pre-built Auth UI for React

https://supabase.com/docs/guides/auth/auth-helpers/auth-ui

MIT License

487 stars 121 forks source link

Remove just-merge and use lodash.merge instead #67

Closed sagarchoudhary96 closed 1 year ago

sagarchoudhary96 commented 1 year ago

What kind of change does this PR introduce?

This PR should fix #65 by removing the just-merge package and using only lodash.merge as dependency.

What is the current behavior?

65 issue is being caused when deploying to vercel with the new nextjs-13 version. Webpack throws issues as merge not defined.

What is the new behavior?

installed just lodash.merge as dependency and using that for merge.

Additional context

Add any other context or screenshots.

sagarchoudhary96 commented 1 year ago

@silentworks can you check it and merge this should solve the problem and also the import cost too.

sagarchoudhary96 commented 1 year ago

@silentworks feels like this https://github.com/angus-c/just/issues/421 might be the issue with just packages which is causing this issue with the vercel build for nextjs app mostly. so as better option is to fallback and use "lodash.merge"

silentworks commented 1 year ago

Closing this one out as the merge function is probably better included in the package instead of relying on third party library.