provide minimum google authentication scope

ndnam198 commented 3 weeks ago

What kind of change does this PR introduce?

Fix a bug not be able to authenticate using Google account

What is the current behavior?

Google throws Exception about lacking logging in scope due to recent Google authentication update

What is the new behavior?

The bare minimum required scope are ['email', 'profile'] for logging in were added, now can authenticate with Google again

dshukertjr commented 3 weeks ago

I thought this update was a bug that was introduced by Google and later was removed. Do you have any thing that says the change was intentional and is here for good?

ndnam198 commented 3 weeks ago

Thanks for reply.

yes, you are right. Previously I have to add these minimum scope values into library code just to pass throught Google authentication in my own project (which also uses this package). As a result, I realize that this package has not used the passed in scopes anywhere. That's why I think it can be good to leverage the variable somehow. But yes, since Google fixed the issue, minimum could be empty array rather than certain values. So I think you can reject the PR for now and maybe apply the changes in the future when there are actual needs.

supabase-community / flutter-auth-ui