supabase-community / godot-engine.supabase

A lightweight addon which integrates Supabase APIs for Godot Engine out of the box.
MIT License
159 stars 17 forks source link

4.x - fixes for verify OTP methods #56

Closed phil-hudson closed 1 year ago

phil-hudson commented 1 year ago

What kind of change does this PR introduce?

Bug fix, feature, docs update, ...

Bug fix

What is the current behavior?

Currently, verifyotp requests will fail as they are not specified to be handled as post requests, so they are called a GET and the API will return a response stating the payload is missing.

I have also added an additional utility function for email based verification, providing an api to specific the verification type

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

phil-hudson commented 1 year ago

@fenix-hub not sure if you were notified, would appreciate review at some point if possible please :)

fenix-hub commented 1 year ago

@phil-hudson Looks good to me, thanks! Mind checking if 3.x is missing this feature too?

phil-hudson commented 1 year ago

yep also missing on 3.x!