search

supabase-community / godot-engine.supabase

A lightweight addon which integrates Supabase APIs for Godot Engine out of the box.
MIT License
159 stars 17 forks source link

allow update method to only update email address #57

Closed phil-hudson closed 1 year ago

phil-hudson commented 1 year ago

usecase : user wants to change email only.

this change prevents a case where sending empty string to the server will cause the request to fail

What kind of change does this PR introduce?

Bug fix, feature, docs update, ...

What is the current behavior?

Please link any relevant issues here.

What is the new behavior?

Feel free to include screenshots if it includes visual changes.

Additional context

Add any other context or screenshots.

fenix-hub commented 1 year ago

Isn't an empty string ignored? Do supabase accepts "" as a new password value?

phil-hudson commented 1 year ago

True, to some extent it depends on the authentication password policies set in Supabase.It would probably be cleaner to add an additionally method for specifically updating the email address.If you agree I can make the changesSent from my iPhoneOn 24 Jan 2023, at 20:30, Nicolò Santilio @.***> wrote: Isn't an empty string ignored? Do supabase accepts "" as a new password value?

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

fenix-hub commented 1 year ago

Agreed. Let's have different methods

fenix-hub commented 1 year ago

Thanks again! :)