supabase-community / postgres_lsp

A Language Server for Postgres
https://supabase.com
MIT License
3.32k stars 62 forks source link

add test for parsing BEGIN, ROLLBACK, COMMIT statements #46

Closed pert5432 closed 10 months ago

pert5432 commented 12 months ago

What kind of change does this PR introduce?

Added test

What is the current behavior?

Transaction statement parsing was not tested

What is the new behavior?

Transaction statement parsing is now tested

closes #36

psteinroe commented 11 months ago

hey @pert5432, thanks for the contribution! Sorry it took so long. We finally finished the parser implementation. Would you mind re-trying the pr? we dropped the snapshot tests, so if you could remove the snapshot and re-try the test that would be great. Thanks a lot.

Also, check out #51 if you have continued interest to contribute.

pert5432 commented 10 months ago

Yo, I'll re-do it, no problem.