search

supabase-community / postgrest-csharp

A C# Client library for Postgrest
https://supabase-community.github.io/postgrest-csharp/api/Postgrest.html
MIT License
114 stars 22 forks source link

minor refactors and clean ups #43

Closed kolosovpetro closed 2 years ago

kolosovpetro commented 2 years ago

I have performed minor refactors and clean ups so that code became less "noisy" :)

acupofjose commented 2 years ago

Wow - you really went through it all - thank you so much! That was not a trivial scan through the codebase. I just had a question about that variable change, otherwise everything else looks great to me. It was in need of a cleanup!

kolosovpetro commented 2 years ago

I just had a question about that variable change

Hi, thanks for the review. What variable exactly?

acupofjose commented 2 years ago

The NULL_VAL variable in QueryFilter.cs

kolosovpetro commented 2 years ago

The NULL_VAL variable in QueryFilter.cs

According to Microsoft's Framework Design Guidelines const values should be named in PascalCase,

Please refer to the following stackoverflow discussion in order to see other details: https://stackoverflow.com/a/242549

acupofjose commented 2 years ago

Ha! I have bad habits apparently. Thanks for the clarification. It’s minor API change, but that’s okay. Thanks again!