Revert "fix: parsing of In filters"

[yusufpapurcu]

Reverts supabase/postgrest-go#13 Could you explain problem with issue and wait us for review? Also why you added panic into function?

[darora]

Hey @yusufpapurcu - the old implementation is completely broken:

• regexp call is passed the arguments in the wrong order. This isn't being detected at the moment because the error returned is just being thrown away; I'm no longer ignoring it which is why there's a panic (shouldn't be triggered unless someone changes the pattern)
• if the regexp didn't match (i.e. reserved characters are not present), the value is just discarded outright
• even if the regexp matches, the value stored is the literal string "cleanValue", rather than the cleanValue
• not a correctness issue, but the naming is confusing: cleanValue is not cleaned in any way, whereas values is (but value isn't)

[inian]

Side note - should we add . and ; to the regex? ref

[yusufpapurcu]

• regexp call is passed the arguments in the wrong order. This isn't being detected at the moment because the error returned is just being thrown away; I'm no longer ignoring it which is why there's a panic (shouldn't be triggered unless someone changes the pattern)

That's a huge mistake I'm sorry for this. You're right we need change this. I will test new form of In filter and reverse commits if it works. Also we can use regexp.MustCompile. This function panics if pattern wrong.

[yusufpapurcu]

Ok I reversed my revert commit. Thanks for help 💯