search

supabase-community / postgrest-go

Isomorphic Go client for PostgREST. (Now Updating)
https://supabase.io
Apache License 2.0
170 stars 27 forks source link

Update ExecuteTo funcs to return count #24

Closed boatilus closed 2 years ago

boatilus commented 2 years ago

Updates the ExecuteTo funcs to return (countType, error), mirroring the recent changes to Execute and ExecuteString, and adds a couple test cases.

This also fixes a couple broken links in the README, peppers in a handful of doc comments, details how some of the tests are set up/how to run, and adds a script in the test directory that can be used to seed the current test DB. So there've been a number of files touched. If desired, I can split these into multiple PRs.

I assumed this PR would be rolled into a v0.0.6 release and updated the version variable accordingly.

yusufpapurcu commented 2 years ago

Hi @boatilus You did a really great job. Only thing that I want to mention is about pr size. If pr focuses only one thing, that makes it really easy to review.

Thanks for your help 💯

boatilus commented 2 years ago

Agreed -- this PR was heavier than necessary. And thanks!