supabase-community / postgrest-go

Isomorphic Go client for PostgREST. (Now Updating)
https://supabase.io
Apache License 2.0
170 stars 27 forks source link

Added ctx arguments to execute #49

Closed assembly-winston closed 2 months ago

assembly-winston commented 3 months ago

What kind of change does this PR introduce?

Added context.Context argument to each variant of the Execute() function, enabling users to pass context-based cancelation to the functions.

What is the current behavior?

There is no way to set deadlines/timeouts for operations to the DB.

What is the new behavior?

We allow the user to pass in a ctx to new variants of the Execute() function that are passed in to http.NewRequestWithContext() rather than the plain http.NewRequest, which defaults to context.Background(), which has no timeout.

Additional context

More info: https://go.dev/doc/database/cancel-operations

assembly-winston commented 3 months ago

Fixes issue 7 in supabase-go: https://github.com/supabase-community/supabase-go/issues/7