Open bharath914 opened 3 months ago
jan-tennert
commented
3 months ago For some reason it fails to create a default settings instance, but if you don't use resumable uploads anyway you can just do this:
createSupabaseClient(
BuildConfig.SUPABASE_PROJECT_URL,
BuildConfig.SUPABASE_API_ANON_KEY,
) {
install(Storage) {
resumable {
cache = MemoryResumableCache()
}
}
install(Postgrest)
}
hieuwu
commented
3 months ago @bharath914 Could you please also share code of the repository? Perhaps there's missing @Inject annotation in the constructor of the SupabaseRepositoryImpl. Also double check @HiltApplication in your Application class and @AndroidEntry point of the Fragment/Activity
jan-tennert
commented
3 months ago Closing due to inactivity. Feel free to reopen!
bharath914
commented
2 months ago Currently Im Using Compose but still the app is crashing
App Module. ` @InstallIn(SingletonComponent::class) @Module object SupaModule {
@Provides
@Singleton
fun provideSupabaseClient(): SupabaseClient {
return createSupabaseClient(
BuildConfig.SUPABASE_PROJECT_URL,
BuildConfig.SUPABASE_API_ANON_KEY,
) {
install(Postgrest)
install(Storage) {
resumable {
cache = MemoryResumableCache()
}
}
}
}
@Provides
@Singleton
fun providePostgrestClient(supabaseClient: SupabaseClient): Postgrest {
return supabaseClient.postgrest
}
@Provides
@Singleton
fun provideSupabaseRepository(supabaseClient: SupabaseClient): SupabaseRepository {
return SupabaseRepositoryImpl(supabaseClient.postgrest)
}}`
Error Logs
FATAL EXCEPTION: main
Process: com.bharath.kiet_student_app, PID: 3323
java.lang.RuntimeException: Unable to create application com.bharath.kiet_student_app.KietApp: java.lang.NullPointerException
at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6764)
at android.app.ActivityThread.-$$Nest$mhandleBindApplication(Unknown Source:0)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2133)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loopOnce(Looper.java:201)
at android.os.Looper.loop(Looper.java:288)
at android.app.ActivityThread.main(ActivityThread.java:7872)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)
Caused by: java.lang.NullPointerException
at com.russhwolf.settings.NoArgKt.Settings(NoArg.kt:32)
at io.github.jan.supabase.storage.resumable.SettingsResumableCache.
bharath914
commented
2 months ago ` import com.bharath.kiet_student_app.BuildConfig import com.bharath.kiet_student_app.data.repository.SupabaseRepositoryImpl import com.bharath.kiet_student_app.domain.repository.SupabaseRepository import dagger.Module import dagger.Provides import dagger.hilt.InstallIn import dagger.hilt.components.SingletonComponent import io.github.jan.supabase.SupabaseClient import io.github.jan.supabase.createSupabaseClient import io.github.jan.supabase.postgrest.Postgrest import io.github.jan.supabase.postgrest.postgrest import io.github.jan.supabase.storage.Storage import javax.inject.Singleton
/**
@InstallIn(SingletonComponent::class) @Module object SupaModule {
@Provides
@Singleton
fun provideSupabaseClient(): SupabaseClient {
return createSupabaseClient(
BuildConfig.SUPABASE_PROJECT_URL,
BuildConfig.SUPABASE_API_ANON_KEY,
) {
install(Storage)
install(Postgrest)
}
}
@Provides
@Singleton
fun providePostgrestClient(supabaseClient: SupabaseClient): Postgrest {
return supabaseClient.postgrest
}
@Provides
@Singleton
fun provideSupabaseRepository(supabaseClient: SupabaseClient): SupabaseRepository {
return SupabaseRepositoryImpl(supabaseClient.postgrest)
}}`
Check this . Same error is happening every time. Other components such as Postgrest is working fine . Storage also working fine before 2.x.x supabase version. But after migrating to 2.x.x then this thing is happening
hieuwu
commented
2 months ago ` import com.bharath.kiet_student_app.BuildConfig import com.bharath.kiet_student_app.data.repository.SupabaseRepositoryImpl import com.bharath.kiet_student_app.domain.repository.SupabaseRepository import dagger.Module import dagger.Provides import dagger.hilt.InstallIn import dagger.hilt.components.SingletonComponent import io.github.jan.supabase.SupabaseClient import io.github.jan.supabase.createSupabaseClient import io.github.jan.supabase.postgrest.Postgrest import io.github.jan.supabase.postgrest.postgrest import io.github.jan.supabase.storage.Storage import javax.inject.Singleton
/**
- @Property SupaModule Module for creating instances of supabase class components
- @sample SupaModule.provideSupabaseRepository
- @see AppModule for better documentation as methods are very similar */
@Installin(SingletonComponent::class) @module object SupaModule {
@Provides @Singleton fun provideSupabaseClient(): SupabaseClient { return createSupabaseClient( BuildConfig.SUPABASE_PROJECT_URL, BuildConfig.SUPABASE_API_ANON_KEY, ) { install(Storage) install(Postgrest) } } @Provides @Singleton fun providePostgrestClient(supabaseClient: SupabaseClient): Postgrest { return supabaseClient.postgrest } @Provides @Singleton fun provideSupabaseRepository(supabaseClient: SupabaseClient): SupabaseRepository { return SupabaseRepositoryImpl(supabaseClient.postgrest) }}`
Check this . Same error is happening every time. Other components such as Postgrest is working fine . Storage also working fine before 2.x.x supabase version. But after migrating to 2.x.x then this thing is happening
It looks like you forgot to provide Storage instance. Please add this block into your SupabaseModule
@Provides
@Singleton
fun provideSupabaseStorage(supabaseClient: SupabaseClient): Storage {
return supabaseClient.storage
}Nothing had been changed
Same error is happening
hieuwu
commented
2 months ago This is the exact what I provided in my sample. Check out the file here https://github.com/hieuwu/product-sample-supabase-kt/blob/main/app/src/main/java/com/example/manageproducts/di/SupabaseModule.kt
Can you also check the Fragment or Activity if it is marked with @AndroidEntryPoint?
bharath914
commented
2 months ago I had checked your code it is same as mine. I also added @AndroidEntryPoint and @HiltAndroidApp.
There is no problem with Dagger Hilt . Also The supabase storage worked fine before the newest dependency upgrades.
I think there is a problem with the sdk itself .
Today I had updated to latest version 2.2.3 as well but the problem still exists.
Solve this problem Asap as my app heavily relies on storage feature.
Currently I Set my buckets to Public and accessing them by urls.
hieuwu
commented
2 months ago Let me try to add MemoryResumableCache. When I upgraded Supabase from 1.0.0 to 2.0.0, all the breaking change is mostly in GoTrue andPostgrest
hieuwu
commented
2 months ago I had checked your code it is same as mine. I also added
@AndroidEntryPointand@HiltAndroidApp. There is no problem with Dagger Hilt . Also The supabase storage worked fine before the newest dependency upgrades. I think there is a problem with the sdk itself . Today I had updated to latest version 2.2.3 as well but the problem still exists. Solve this problem Asap as my app heavily relies on storage feature. Currently I Set my buckets to Public and accessing them by urls.
Can you try example from this https://supabase.com/docs/reference/kotlin/storage-from-upload?example=create-resumable-upload ?
hieuwu
commented
2 months ago I tried with version 2.2.3 in my sample and it works well. Please double check again @bharath914 . It would be great if you provide the minimum code that cause the crash
bharath914
commented
2 months ago I will check and update here
bharath914
commented
2 months ago I tried again but same result app is crashing for no reason
General Info
Version(s)
2.1.5
Target(s)
1.12.0
What happened? (include your code)
The sdk cannot install storage client when using hilt and I checked for mutliple projects and this thing happens the same. The app is crashing . Here is the code snippet of it. ` package com.bharath.kiet_student_app.di
import com.bharath.kiet_student_app.BuildConfig import com.bharath.kiet_student_app.data.repository.SupabaseRepositoryImpl import com.bharath.kiet_student_app.domain.repository.SupabaseRepository import dagger.Module import dagger.Provides import dagger.hilt.InstallIn import dagger.hilt.components.SingletonComponent import io.github.jan.supabase.SupabaseClient import io.github.jan.supabase.createSupabaseClient import io.github.jan.supabase.postgrest.Postgrest import io.github.jan.supabase.postgrest.postgrest
import io.github.jan.supabase.storage.Storage import io.github.jan.supabase.storage.storage import javax.inject.Singleton
/**
@InstallIn(SingletonComponent::class) @Module object SupaModule {
} ` Please fix this issue ASAP.
Steps To Reproduce (optional)
Please
Relevant log output (optional)