search

supabase / auth

A JWT based API for managing users and issuing JWT tokens
https://supabase.com/docs/guides/auth
MIT License
1.55k stars 374 forks source link

Self Hosting: GOTRUE_MAILER_SECURE_EMAIL_CHANGE_ENABLED not implemented? #1813

Closed riccardolardi closed 3 weeks ago

riccardolardi commented 1 month ago

On a self hosted Supabase: changing the email via generateLink() and using the returned action_link as described in the docs does only seem to work when both links are generated and clicked (current and new email) - GOTRUE_MAILER_SECURE_EMAIL_CHANGE_ENABLED does not seem to have any effect when enabled in docker-compose.yml also since it doesn't seem to have any implementation in the auth codebase? https://github.com/supabase/auth/blob/6ac56244bf885729b6ed8815dbed39dc296a927b/internal/api/verify.go#L524

Is this stale / deprecated? In a self-hosted environment, due to this I don't seem able to disable the need for double checking / clicking both links (old and new email).

Interestingly, in local dev environment it does indeed work (by setting double_confirm_changes = false in supabase/config.toml) so it seems it is only related to self-hosting?

riccardolardi commented 3 weeks ago

I don't know what went wrong earlier but it works now (maybe I forgot to restart the containers).