fix(reset): ensure _supabase connections disconnect before reset - Githubissues

supabase / cli

Supabase CLI. Manage postgres migrations, run Supabase locally, deploy edge functions. Postgres backups. Generating types from your database schema.

https://supabase.com/docs/reference/cli/about

MIT License

1.09k stars 212 forks source link

fix(reset): ensure _supabase connections disconnect before reset #2904

Closed avallete closed 20 hours ago

avallete commented 5 days ago

What kind of change does this PR introduce?

Ensure db reset command work properly on postgres v14

The root cause is that while in pg15+ DATABASE DROP FORCE kill all connections, it's not the case for pg14. Requiring to manually disconnect all connections before performing the reset.

Additional context

Closes #2903

coveralls commented 5 days ago

Pull Request Test Coverage Report for Build 12005516982

Details

29 of 31 (93.55%) changed or added relevant lines in 3 files are covered.
11 unchanged lines in 2 files lost coverage.
Overall coverage increased (+0.02%) to 59.57%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/db/reset/reset.go	19	21	90.48%
<!--	Total:	29	31	93.55%	-->

Files with Coverage Reduction	New Missed Lines	%
internal/gen/keys/keys.go	5	12.9%
internal/utils/misc.go	6	71.3%
<!--	Total:	11		-->

Totals
Change from base Build 12004204692:	0.02%
Covered Lines:	6396
Relevant Lines:	10737

💛 - Coveralls