search

supabase / gotrue-dart

A dart client library for GoTrue.
MIT License
46 stars 37 forks source link

fix: signedIn event will not fire for passwordRecovery event #136

Closed dshukertjr closed 1 year ago

dshukertjr commented 1 year ago

What kind of change does this PR introduce?

Currently, signedIn event fires for every passwordRecovery event, which is not so intuitive. This PR prevents from signedIn event from firing for a passwordRecovery event.

Copied over from this js PR https://github.com/supabase/gotrue-js/pull/629/files

Vinzent03 commented 1 year ago

The Session recovery succedes after retries test runs infinitely. The expect is run and the test itself finishes, but the vscode test tab shows an infinity running tearDownAll test. That's strange, because the last commit didn't have this issue. Maybe a dependency?

dshukertjr commented 1 year ago

Interesting. Just stepped out for a bit, but will take a look later. Thanks for the heads up!

dshukertjr commented 1 year ago

Oh, so the tests are now passing huh? Thanks for re-running them @Vinzent03 !

Vinzent03 commented 1 year ago

@dshukertjr No, I pushed a fix to this pr.

dshukertjr commented 1 year ago

Ah, missed it! Thanks for that!